-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/interval] Create the initial structure for the new processor #30756
[processor/interval] Create the initial structure for the new processor #30756
Conversation
111d576
to
27b1196
Compare
@RichieSams, looks like the collector modules need updating again. Feel free to ping me to restart CI |
@djaglowski There are failing CI checks, but it looks to be all go.mod version mismatch issues. I keep rebasing to HEAD, but versions are changing faster than I can rebase and re-test. :( How do you suggest we proceed? |
Add a new processor that aggregates metrics and periodically forwards the latest values to the next component in the pipeline
And to satisfy the tests, since it's not in components.go yet
faf9bce
to
a6f7d65
Compare
@djaglowski I think we're good now to re-trigger CI. 🤞 |
@RichieSams, apologies for the churn here. I think we got unlucky trying to do this while a release is being cut. Still, we cannot merge without passing all required checks. I've restarted CI. |
@djaglowski One of the checks if failing because my metadata.yml doesn't have values in the stability section:
I removed that section though, because another check wants to make sure that the component exists in components.go. But according to the CONTRIBUTING.md we don't add that until it's "ready". Can you assist? |
@RichieSams, I think we need the stability section and it's ok for the component to be in |
Ah, I may have been confused about some of the language here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components I also didn't realize there is a |
4de1525
to
2e80ee7
Compare
Thanks for helping get it in! I'm working on the implementation. Initial PR probably tomorrow or next week |
This broke mainline, seems a bad merge https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7662556481/job/20884054028 |
Description:
Adds a new processor that aggregates metrics and periodically forwards the latest values to the next component in the pipeline.
NOTE: As per the CONTRIBUTING.md recommendations, this PR only creates the basic structure of the processor. The concrete implementation will come as a separate followup PR
Link to tracking Issue:
#29461
Testing:
This is just the basic structure, so no tests yet, other than the auto-generated ones for metadata.yaml
Documentation:
This adds the basic README, but more will be added in the followup PR which adds the concrete implementation