[processor/deltatocumulative]: Sums #30707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/metrics: primitives for working on a generalized idea of metrics internal/streams: primitives for working on streams internal/delta: delta sum aggregation
emits aggregated metrics on a configured interval to the next consumer.Metrics
drops ooo support for now, which eliminates the need for sophisticated grouping that was present before. this radically simplifies the core part of this exporter. ooo support will be added back by queueing and sorting delta samples instead.
26 tasks
2 tasks
RichieSams
reviewed
Jan 23, 2024
RichieSams
reviewed
Jan 23, 2024
RichieSams
reviewed
Jan 23, 2024
RichieSams
reviewed
Jan 25, 2024
aknuds1
reviewed
Jan 26, 2024
|
@RichieSams would you be interested in becoming second CODEOWNER on this component? More than happy to do the same for your intervalprocessor, keeping the current engineering focus split :) |
jpkrohling
reviewed
Feb 15, 2024
processor/deltatocumulativeprocessor/internal/delta/delta_test.go
Outdated
Show resolved
Hide resolved
6 tasks
|
@djaglowski @RichieSams please take a final look :) |
That's a great idea. Let's do both. |
Code / algorithm looks good to me. Question: When #31017 is merged, do you plan to refactor this code to utilize the new types? |
djaglowski
approved these changes
Feb 15, 2024
yes absolutely, just didn't want to introduce more blocking inter-dependencies for now! |
jpkrohling
approved these changes
Feb 15, 2024
jpkrohling
pushed a commit
that referenced
this pull request
Feb 19, 2024
Adds a new internal, _experimental_ package `metrics/identity` which implements identity types for resource, scope, metric and stream. This is closely related to work being done in #30707 and #30827. The package is specifically experimental, as it shall be treated as an internal component to above processors which may change at any moment as long as those are under active initial development. /cc @jpkrohling @djaglowski @RichieSams
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Implements major component functionality: - [x] metrics identification (`metrics.Ident`) and stream identification (`streams.Ident`) - [x] abstract data layer `data.Point` that keeps processing code data type (sum, histogram, exp histogram) agnostic - [x] `delta.Accumulator` stream processor for accumulating any `data.Point` **Link to tracking Issue:** open-telemetry#30705 **Testing:** Done **Documentation:** <kbd>TODO</kbd>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Adds a new internal, _experimental_ package `metrics/identity` which implements identity types for resource, scope, metric and stream. This is closely related to work being done in open-telemetry#30707 and open-telemetry#30827. The package is specifically experimental, as it shall be treated as an internal component to above processors which may change at any moment as long as those are under active initial development. /cc @jpkrohling @djaglowski @RichieSams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements major component functionality:
metrics.Ident) and stream identification (streams.Ident)data.Pointthat keeps processing code data type (sum, histogram, exp histogram) agnosticdelta.Accumulatorstream processor for accumulating anydata.PointLink to tracking Issue: #30705
Testing: Done
Documentation: TODO