[chore] add headers to request #30685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EOjeah
requested review from
MovieStoreGuy and
andrzej-stencel
as code owners
crobert-1
reviewed
Jan 19, 2024
| @@ -78,6 +78,9 @@ func (ze *zipkinExporter) pushTraces(ctx context.Context, td ptrace.Traces) erro | |||
| if err != nil { | |||
| return fmt.Errorf("failed to push trace data via Zipkin exporter: %w", err) | |||
| } | |||
| for k, v := range ze.clientSettings.Headers { | |||
There was a problem hiding this comment.
Left a comment in our discussion in the issue, I don't think this PR is a valid update in its current form.
|
#30679 has been closed, I'll close this for now as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add headers to POST request made to zipkin server with the zipkinexporter
Link to tracking Issue: #30679