Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jmxreceiver resource_attributes example #30646

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

neilfordyce
Copy link
Contributor

Description:
Updating the jmxreceiver resource_attributes example in the readme. Faced an error when starting the collector telling us it should be a map, not a string.

Testing:
Changed to a map and it worked.

@neilfordyce neilfordyce requested review from a team and mx-psi January 17, 2024 16:04
@github-actions github-actions bot added the receiver/jmx JMX Receiver label Jan 17, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilfordyce

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 17, 2024
@codeboten codeboten merged commit 2bbbcbb into open-telemetry:main Jan 17, 2024
90 of 91 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 17, 2024
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this pull request Jan 18, 2024
Updating the jmxreceiver resource_attributes example in the readme.
Faced an error when starting the collector telling us it should be a
map, not a string.

**Testing:**
Changed to a map and it worked.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Updating the jmxreceiver resource_attributes example in the readme.
Faced an error when starting the collector telling us it should be a
map, not a string.

**Testing:**
Changed to a map and it worked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/jmx JMX Receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants