[receiver/k8scluster] fix node resource attributes #30641
Conversation
povilasv
force-pushed
the
k8scluster/fix-resource-attributes
branch
from
768fab2 to
c5110da
Compare
| @@ -22,9 +22,12 @@ resourceMetrics: | |||
| - key: os.description | |||
| value: | |||
| stringValue: Ubuntu 22.04.1 LTS | |||
| - key: os.version | |||
| - key: os.kernel.version | |||
There was a problem hiding this comment.
lgtm, but how about we add it to the semantics-convention and see if the group has any recommendations?
There was a problem hiding this comment.
I agree with opening a PR to add it to the semantic conventions. I'd also like to get this PR merged before the next release so we don't start publishing a value for os.version incorrectly. I am ok adding a new attribute that isnt stable in the semconv yet since it is off by default, but I dont like implementing a well-defined semconv incorrectly
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user] |
There was a problem hiding this comment.
Given that os.version is not released yet, it's better to update the existing changelog entry that adding another one on top
povilasv
force-pushed
the
k8scluster/fix-resource-attributes
branch
2 times, most recently
from
717b66d to
2dc7440
Compare
povilasv
force-pushed
the
k8scluster/fix-resource-attributes
branch
from
0d82c1d to
543e3ea
Compare
|
For now I removed os.version, will work on adding os.kernel.version to semantic conventions. So this PR adds os.type, and changed changelog for previous PR to only add os.description |
Description:
Link to tracking Issue:
#30342
Testing:
Documentation: