Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] Removes a couple unnecessary functions from reader.Reader #30629

Merged

Conversation

djaglowski
Copy link
Member

Depends on #30623

@djaglowski djaglowski force-pushed the pkg-stanza-reader-more-tests branch from 4a168ff to 20ba36e Compare January 17, 2024 14:44
@djaglowski djaglowski marked this pull request as ready for review January 17, 2024 16:05
@djaglowski djaglowski requested a review from a team January 17, 2024 16:05
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@djaglowski
Copy link
Member Author

@codeboten, I've rebased

@codeboten codeboten merged commit eb3c755 into open-telemetry:main Jan 17, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 17, 2024
@djaglowski djaglowski deleted the pkg-stanza-reader-more-tests branch January 17, 2024 20:59
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this pull request Jan 18, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants