Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8sattributes lifecycle #30387

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 10, 2024

Description:
Change k8sattributes processor to be in line with lifecycle expectations of a component.

@atoulme atoulme requested a review from a team January 10, 2024 07:42
@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Jan 10, 2024
@atoulme atoulme force-pushed the k8sattributes_lifecycle branch from 851b409 to ea5e8d8 Compare January 10, 2024 07:43
@atoulme atoulme force-pushed the k8sattributes_lifecycle branch 2 times, most recently from 773d059 to 357bc77 Compare January 10, 2024 08:25
@fatsheep9146
Copy link
Contributor

@atoulme failed checks said

go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

@atoulme atoulme force-pushed the k8sattributes_lifecycle branch from 357bc77 to f7b2292 Compare January 10, 2024 16:14
@bogdandrutu bogdandrutu merged commit c5b5356 into open-telemetry:main Jan 10, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 10, 2024
bogdandrutu pushed a commit that referenced this pull request Jan 10, 2024
All processors have moved to use generated tests
(#30387
is the last one), we can move to deleting this test now.
@atoulme atoulme deleted the k8sattributes_lifecycle branch January 10, 2024 22:12
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
**Description:** 
Change k8sattributes processor to be in line with lifecycle expectations
of a component.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…#30388)

All processors have moved to use generated tests
(open-telemetry#30387
is the last one), we can move to deleting this test now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/k8sattributes k8s Attributes processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants