Fix for - syncTargetAllocator in prometheus metrics receiver doesnt detect regex changes in metrics relabel config #30258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmichandrashekar
requested review from
Aneurysm9 and
dashpole
as code owners
github-actions
bot
requested review from
chrroberts-pure,
dgoscn,
dineshg13,
liustanley,
mackjmr and
pmcollins
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
jpkrohling
pushed a commit
that referenced
this pull request
Jul 11, 2024
…n relabel config (#32127) **Description:** <Describe what has changed.> Fixing a bug - With the Targetallocator component in prometheus receiver, when prometheus scrape config is updated for metric relabel config with just regex change, the prometheus metrics receiver doesn't update the hash and hence doesn't pick up the metrics relabel config with the new regex. This is because the **regex** struct has unexported fields. This fix similar to the fix made in [opentelemetry-operator](open-telemetry/opentelemetry-operator#2171) fixes this issue by taking into account the unexported fields as well. **Link to tracking Issue:** - #29313 **Testing:** Tested to make sure that just the regex changes in metric relabeling gets picked up with TargetAllocator enabled. Reopening this PR since the old one(#30258) got closed due to inactivity. --------- Co-authored-by: David Ashpole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - With the Targetallocator component in prometheus receiver, when prometheus scrape config is updated for metric relabel config with just regex change, the prometheus metrics receiver doesn't update the hash and hence doesn't pick up the metrics relabel config with the new regex.
This is because the regex struct has unexported fields. This fix similar to the fix made in opentelemetry-operator fixes this issue by taking into account the unexported fields as well.
Link to tracking Issue: - #29313
Testing: Tested to make sure that just the regex changes in metric relabeling gets picked up with TargetAllocator enabled.