[clickhouse/exporter] Fix clickhouse exporter insert metrics data bug

.chloggen/fix_ck_exporter_insert_metrics_bug.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: clickhouseexporter
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fix clickhouse exporter insert metrics data bug
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [30210]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

exporter/clickhouseexporter/exporter_metrics_test.go

@@ -12,6 +12,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/ClickHouse/clickhouse-go/v2"
 	"github.com/stretchr/testify/require"
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/pmetric"
@@ -97,6 +98,29 @@ func TestExporter_pushMetricsData(t *testing.T) {
 
 		require.Equal(t, int32(15), items.Load())
 	})
+	t.Run("check traceID and spanID", func(t *testing.T) {
+		initClickhouseTestServer(t, func(query string, values []driver.Value) error {
+			if strings.HasPrefix(query, "INSERT INTO otel_metrics_gauge") {
+				require.Equal(t, clickhouse.ArraySet{"0102030000000000"}, values[18])
+				require.Equal(t, clickhouse.ArraySet{"01020300000000000000000000000000"}, values[19])
+			}
+			if strings.HasPrefix(query, "INSERT INTO otel_metrics_histogram") {
+				require.Equal(t, clickhouse.ArraySet{"0102030000000000"}, values[20])
+				require.Equal(t, clickhouse.ArraySet{"01020300000000000000000000000000"}, values[21])
+			}
+			if strings.HasPrefix(query, "INSERT INTO otel_metrics_sum ") {
+				require.Equal(t, clickhouse.ArraySet{"0102030000000000"}, values[18])
+				require.Equal(t, clickhouse.ArraySet{"01020300000000000000000000000000"}, values[19])
+			}
+			if strings.HasPrefix(query, "INSERT INTO otel_metrics_exponential_histogram") {
+				require.Equal(t, clickhouse.ArraySet{"0102030000000000"}, values[24])
+				require.Equal(t, clickhouse.ArraySet{"01020300000000000000000000000000"}, values[25])
+			}
+			return nil
+		})
+		exporter := newTestMetricsExporter(t)
+		mustPushMetricsData(t, exporter, simpleMetrics(1))
+	})
 }
 
 func Benchmark_pushMetricsData(b *testing.B) {

exporter/clickhouseexporter/internal/exponential_histogram_metrics.go

@@ -154,8 +154,8 @@ func (e *expHistogramMetrics) insert(ctx context.Context, db *sql.DB) error {
 					attrs,
 					times,
 					values,
-					traceIDs,
 					spanIDs,
+					traceIDs,
 					uint32(dp.Flags()),
 					dp.Min(),
 					dp.Max(),

exporter/clickhouseexporter/internal/gauge_metrics.go

@@ -128,8 +128,8 @@ func (g *gaugeMetrics) insert(ctx context.Context, db *sql.DB) error {
 					attrs,
 					times,
 					values,
-					traceIDs,
 					spanIDs,
+					traceIDs,
 				)
 				if err != nil {
 					return fmt.Errorf("ExecContext:%w", err)

exporter/clickhouseexporter/internal/histogram_metrics.go

@@ -140,8 +140,8 @@ func (h *histogramMetrics) insert(ctx context.Context, db *sql.DB) error {
 					attrs,
 					times,
 					values,
-					traceIDs,
 					spanIDs,
+					traceIDs,
 					uint32(dp.Flags()),
 					dp.Min(),
 					dp.Max(),

exporter/clickhouseexporter/internal/sum_metrics.go

@@ -132,8 +132,8 @@ func (s *sumMetrics) insert(ctx context.Context, db *sql.DB) error {
 					attrs,
 					times,
 					values,
-					traceIDs,
 					spanIDs,
+					traceIDs,
 					int32(model.sum.AggregationTemporality()),
 					model.sum.IsMonotonic(),
 				)