Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azuremonitor] do not skip lifecycle tests #30198

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[receiver/azuremonitor] do not skip lifecycle tests #30198

merged 1 commit into from
Dec 28, 2023

Conversation

cheskayang
Copy link
Contributor

@cheskayang cheskayang commented Dec 24, 2023 •
edited
Loading

hello this is my first PR :)

Description:

  • remove the skip_lifecycle flag
  • regenerate tests
  • fix failing tests

Link to tracking Issue:
#30038

Testing:
existing tests

Documentation:
no change

@cheskayang cheskayang requested a review from a team December 24, 2023 02:09
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 24, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cheskayang / name: Cheska (Qian) Yang (ff56cef)

@fatsheep9146 fatsheep9146 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 25, 2023
@fatsheep9146
Copy link
Contributor

@codeboten could you help approve running all checks? Some checks could only be approved by maintainers.

@codeboten
Copy link
Contributor

Thanks @cheskayang!

@codeboten codeboten merged commit fbae4bb into open-telemetry:main Dec 28, 2023
90 of 91 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 28, 2023
@cheskayang cheskayang deleted the receiver-azure-monitor-do-not-skip-lifecycle branch December 31, 2023 01:46
@ChrsMark ChrsMark mentioned this pull request Jan 8, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@cheskayang @cparkins
[receiver/azuremonitor] do not skip lifecycle tests (open-telemetry#3…
f011dc0 
…0198)

hello this is my first PR :)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
- remove the skip_lifecycle flag
- regenerate tests
- fix failing tests

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#30038

**Testing:** <Describe what testing was performed and which tests were
added.>
existing tests

**Documentation:** <Describe the documentation added.>
no change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

Assignees

@fatsheep9146 fatsheep9146

Labels
receiver/azuremonitor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cheskayang @fatsheep9146 @codeboten