Update log collection #3017
Merged
Update log collection #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3017 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 464 464
Lines 22846 22846
=======================================
+ Hits 20916 20917 +1
+ Misses 1437 1436 -1
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Apr 8, 2021
| @@ -14,11 +14,11 @@ receivers: | |||
| id: get-format | |||
| routes: | |||
| - output: parser-docker | |||
| expr: '$$record matches "^\\{"' | |||
There was a problem hiding this comment.
Please also remember to update the helm chart.
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-helm-charts
that referenced
this pull request
Apr 14, 2021
Follows [#88 (opentelemetry-log-collection)](open-telemetry/opentelemetry-log-collection#88) and [#3017 (opentelemetry-collector-contrib)](open-telemetry/opentelemetry-collector-contrib#3017)
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
Updates `opentelemetry-log-collection` to [v0.17.0](https://github.com/open-telemetry/opentelemetry-log-collection/releases/tag/v0.17.0)
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
…ng it up (#3597) Split off from PR #3017, as requested to firstly add the implementation unwired to the exporter itself to help the reviewers easily understand Uses an off the shelf WAL implementation to add capabilities to the Prometheus remote exporter using github.com/tidwall/wal. By default the WAL will be on and to configure the WAL location, please use this prometheusremotewrite exporter YAML configuration: ```yaml exporters: prometheusremotewrite: endpoint: "http://some.url:9411/api/prom/push" wal: directory: ./waldir/wal_directory truncate_frequency: 200s cache_size: 300 ``` whose fields are quite similar to Prometheus' WAL fields per https://docs.google.com/document/d/1cCcoFgjDFwU2n823tKuMvrIhzHty4UDyn0IcfUHiyyI/edit#heading=h.mlf37ibqjgov We are using an off-the-shelf WAL because: By the time that we get OTLP metrics, we can convert to Prometheus proto, but trying to implement the Prometheus storage interfaces would involve either by-passing to-Prometheus-Proto and then save to Prometheus raw Go, then retrieve Prometheus raw Go and then convert to Prometheus Proto. It is much easier to get an off the shelf WAL implementation and add it to the Prometheus implementation. The next PR after this one will involve hooking it into the actual Prometheus Remote Write exporter. Updates open-telemetry/prometheus-interoperability-spec#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
opentelemetry-log-collectionto v0.17.0