[pkg/ottl] Validate Keys are used #30162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
evan-bradley
approved these changes
Jan 2, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** This PR updates OTTL's validation logic to validate the keys are considered during path parsing. Unlike the path, keys are needed during hot path execution. For that reason, the contexts need all the keys during parsing, not an individual key that might be linked to the next key. This PR updates the Path interface to have a list of keys instead of a link to the first Key. This keeps the keys interaction closer to the original key struct from the grammar, which means when the interfaces release we have less breaking changes. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#30051 **Testing:** <Describe what testing was performed and which tests were added.> Added unit tests to validate that indexing fails on paths that dont use keys and pass on paths that allow keys. --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates OTTL's validation logic to validate the keys are considered during path parsing.
Unlike the path, keys are needed during hot path execution. For that reason, the contexts need all the keys during parsing, not an individual key that might be linked to the next key.
This PR updates the Path interface to have a list of keys instead of a link to the first Key. This keeps the keys interaction closer to the original key struct from the grammar, which means when the interfaces release we have less breaking changes.
Link to tracking Issue:
Closes #30051
Testing:
Added unit tests to validate that indexing fails on paths that dont use keys and pass on paths that allow keys.