Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/clickhouse] Fix broken makefile command for examples #30161

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[chore][exporter/clickhouse] Fix broken makefile command for examples #30161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exporter/clickhouseexporter/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
include ../../Makefile.Common

local-run-example:
cd ../../ && GOOS=linux go build -o ./local/otelcontribcol ./cmd/otelcontribcol
cd ../../cmd/otelcontribcol && GOOS=linux go build -o ../../local/otelcontribcol
cd example && docker-compose up -d
recreate-otel-collector:
cd ../../ && GOOS=linux go build -o ./local/otelcontribcol ./cmd/otelcontribcol
cd ../../ && make otelcontribcol
cd example && docker-compose up --build otelcollector
2 changes: 1 addition & 1 deletion exporter/clickhouseexporter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ SELECT Timestamp as log_time,
toString(Links.TraceId)
FROM otel_traces
WHERE ServiceName = 'clickhouse-exporter'
AND SpanAttributes['peer.service'] = 'tracegen-server'
AND SpanAttributes['peer.service'] = 'telemetrygen-server'
AND Timestamp >= NOW() - INTERVAL 1 HOUR
Limit 100;
```
Expand Down
5 changes: 3 additions & 2 deletions exporter/clickhouseexporter/example/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ services:
stop_signal: SIGKILL

# Traces generator
tracegen:
telemetrygen:
build:
context: ../../../cmd/tracegen/
context: ../../../cmd/telemetrygen/
command:
- traces
- --otlp-endpoint=otelcollector:4317
- --otlp-insecure
- --rate=100
Expand Down