[exporter/zipkin] use confighttp.DefaultHTTPClientSettings #29931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
MovieStoreGuy and
andrzej-stencel
as code owners
atoulme
force-pushed
the
zipkinexporter_clientsettings
branch
from
58ccd45
to
271cdad
Compare
andrzej-stencel
approved these changes
Dec 18, 2023
bogdandrutu
approved these changes
Dec 18, 2023
crobert-1
approved these changes
Dec 18, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…metry#29931) **Description:** Modernize the logic of validation by moving to config Validate from the Start function Use the HTTPClientDefaultSettings defaults when setting the config. **Link to tracking Issue:** open-telemetry#6641 **Testing:** Updated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modernize the logic of validation by moving to config Validate from the Start function
Use the HTTPClientDefaultSettings defaults when setting the config.
Link to tracking Issue:
#6641
Testing:
Updated tests.