[pkg/ottl] Unexport the grammar's enumSymbol #29924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
TylerHelmuth
added
the
Skip Changelog
evan-bradley
pushed a commit
that referenced
this pull request
Dec 18, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** On the continuing quest to unexport the grammar, this PR unexports the grammar's constants. Depends on open-telemetry#29924 Link to tracking Issue: Related to open-telemetry#22744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On the continuing quest to unexport the grammar, this PR unexports the grammar's
EnumSymboland replaces it with a truely public facingEnumSymbol. This lets us in the future, if needed, change how the grammar parses enums without change how contexts represent them.Link to tracking Issue:
Related to #22744