Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/remotetap] add basic implementation of the extension #29726

Closed
wants to merge 1 commit into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 9, 2023

This makes the implementation work in a simple setting, rendering the JSON output of the data traversing the extension via websocket with a HTML select input to pick the tap to connect to.

From this implementation, there are a number of improvements we can work towards making:

  • It might make more sense for processors to register with extensions rather than having the extension define the processor endpoints. Because extensions don't have access to the processor list, you end up having to enter the processor name and endpoint in the extension config right now, which is less than ideal.
    If the processor can register with this extension, however, I'd like it to be through a shared interface other extensions can also use, so we can over time have multiple extensions register with taps. This would allow other extensions to benefit from taps.
  • The extension is very, very simple - a toy implementation to allow the community to understand the remote tap mechanism and take it from there.
Screenshot 2023-12-09 at 11 34 52

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 24, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants