[pkg/ottl] Add ConditionSequence struct #29339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
|
/cc @evan-bradley |
TylerHelmuth
force-pushed
the
ottl-condition-sequence
branch
from
777e4b4 to
c06f7b9
Compare
evan-bradley
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new
ConditionSequencestruct to help handle processing a list of Conditions. The primary reason to use aConditionSequenceis to let the struct handle errors. Since that is its defining purpose, I opted to makeErrorModea required argument in the "constructor" instead of an Option.I also update
internal/filterottlto use this struct instead ofStatements. This is a non-breaking change.If we like this pattern, I will do a breaking change to replace
Statementswith a similarStatementSequencestruct in a future PR .See these structs implemented in components here: #29294
Link to tracking Issue:
Related to #13545
Testing:
Added new tests
Documentation:
Added godoc comments