Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Deprecate peer_service_aggregation in favor of peer_tags_aggregation #29089

Merged
merged 6 commits into from
Nov 14, 2023
Merged

[exporter/datadog] Deprecate peer_service_aggregation in favor of peer_tags_aggregation #29089

merged 6 commits into from
Nov 14, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Nov 9, 2023

Description:
Deprecate peer_service_aggregation in favor of peer_tags_aggregation. Counterpart of DataDog/datadog-agent#20550.

@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components labels Nov 9, 2023
@songy23 songy23 marked this pull request as ready for review November 10, 2023 15:07
@songy23 songy23 requested a review from mx-psi as a code owner November 10, 2023 15:07
@songy23 songy23 requested a review from a team November 10, 2023 15:07
@songy23 songy23 requested a review from dmitryax as a code owner November 10, 2023 15:07
@songy23
Copy link
Member Author

songy23 commented Nov 10, 2023

cc @jdgumz

mx-psi
mx-psi reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the flag to

opentelemetry-collector-contrib/exporter/datadogexporter/config_warnings.go

Line 27 in 1d4cf91

var renamedSettings = []deprecatedError{
?

@songy23 songy23 requested a review from a team November 13, 2023 17:26
@songy23 songy23 requested a review from mx-psi November 14, 2023 15:13
mx-psi
mx-psi approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we wait for @jdgumz to review?

songy23
songy23 commented Nov 14, 2023
View reviewed changes
Copy link
Member Author

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this should be good to go, it is mostly just making use of DataDog/datadog-agent#20550.

@mx-psi mx-psi merged commit 546340d into open-telemetry:main Nov 14, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
@songy23 songy23 deleted the peer-service branch November 14, 2023 15:53
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@songy23 @RoryCrispin
[exporter/datadog] Deprecate peer_service_aggregation in favor of pee…
78868d4 
…r_tags_aggregation (open-telemetry#29089)

**Description:**
Deprecate peer_service_aggregation in favor of peer_tags_aggregation.
Counterpart of DataDog/datadog-agent#20550.
@mx-psi mx-psi mentioned this pull request Dec 4, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@Aneurysm9 Aneurysm9

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components testbed
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @mx-psi @Aneurysm9