Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/golden] internal/coreinternal/golden -> pkg/golden #28636

Merged
merged 7 commits into from
Oct 27, 2023
Merged

[pkg/golden] internal/coreinternal/golden -> pkg/golden #28636

merged 7 commits into from
Oct 27, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 26, 2023

Description:
Move the golden package to pkg/golden so it can be available to downstream projects.

Link to tracking Issue:
Fixes #28594

@atoulme atoulme requested review from a team October 26, 2023 06:07
@djaglowski
Copy link
Member

Just need to run make goporto

@djaglowski djaglowski merged commit cd92432 into open-telemetry:main Oct 27, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 27, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@atoulme @djaglowski @jmsnll
[pkg/golden] internal/coreinternal/golden -> pkg/golden (open-telemet…
f3c15c8 
…ry#28636)

**Description:**
Move the golden package to pkg/golden so it can be available to
downstream projects.

**Link to tracking Issue:**
Fixes open-telemetry#28594

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@atoulme @djaglowski @RoryCrispin
[pkg/golden] internal/coreinternal/golden -> pkg/golden (open-telemet…
9a788ec 
…ry#28636)

**Description:**
Move the golden package to pkg/golden so it can be available to
downstream projects.

**Link to tracking Issue:**
Fixes open-telemetry#28594

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 left review comments

@djaglowski djaglowski djaglowski approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@arminru arminru Awaiting requested review from arminru

Assignees

@fatsheep9146 fatsheep9146

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol connector/count connector/exceptions connector/routing connector/spanmetrics exporter/alibabacloudlogservice Alibaba components exporter/awsemf awsemf exporter exporter/awskinesis exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/cassandra exporter/clickhouse exporter/datadog Datadog components exporter/dataset exporter/dynatrace exporter/elasticsearch exporter/file exporter/honeycombmarker exporter/instana exporter/kafka exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/opencensus exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/sapm exporter/sentry exporter/signalfx exporter/skywalking exporter/splunkhec exporter/tanzuobservability exporter/tencentcloudlogservice exporter/zipkin extension/encoding/jaegerencoding extension/encoding/textencoding extension/encoding/zipkinencoding internal/core internal/filter pkg/ottl pkg/pdatatest pkg/resourcetotelemetry pkg/stanza pkg/translator/azure pkg/translator/jaeger pkg/translator/loki pkg/translator/opencensus pkg/translator/prometheus pkg/translator/signalfx pkg/translator/zipkin processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/filter Filter processor processor/logstransform Logs Transform processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/resource Resource processor processor/routing Routing processor processor/span processor/spanmetrics Span Metrics processor processor/tailsampling Tail sampling processor processor/transform Transform processor receiver/activedirectoryds receiver/aerospike receiver/apache receiver/apachespark receiver/awscloudwatch receiver/awsxray receiver/azureeventhub receiver/azuremonitor receiver/bigip receiver/cloudflare receiver/collectd receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/filelog receiver/flinkmetrics receiver/fluentforward receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/iis receiver/jmx JMX Receiver receiver/journald receiver/k8scluster receiver/k8sobjects receiver/kafkametrics
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.

Move internal/golden to pkg/golden
5 participants
@atoulme @sakulali @djaglowski @songy23 @fatsheep9146