Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8sclusterreceiver] add k8s.node.condition metric #27838

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 18, 2023

Description:

Add new k8s.node.condition metric, so that we can deprecate k8s.node.condition_* metrics.

Link to tracking Issue:

#27617

Testing:

  • added unit tests

Documentation:

  • added docs

@povilasv povilasv force-pushed the k8sclusterreceiver-add-k8s-node-condition branch from f88e9fb to 1b2154b Compare October 18, 2023 11:12
@povilasv povilasv force-pushed the k8sclusterreceiver-add-k8s-node-condition branch 5 times, most recently from 3670c63 to 41a9326 Compare October 19, 2023 06:45
@povilasv povilasv marked this pull request as ready for review October 19, 2023 07:41
@povilasv povilasv requested a review from a team October 19, 2023 07:41
@povilasv povilasv force-pushed the k8sclusterreceiver-add-k8s-node-condition branch 3 times, most recently from 22a833e to d4c1565 Compare October 20, 2023 11:05
@povilasv povilasv force-pushed the k8sclusterreceiver-add-k8s-node-condition branch from d4c1565 to 82a37e9 Compare October 20, 2023 11:27
@povilasv povilasv requested a review from TylerHelmuth October 20, 2023 12:04
@jpkrohling jpkrohling merged commit 67fcaad into open-telemetry:main Oct 24, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 24, 2023
@povilasv povilasv deleted the k8sclusterreceiver-add-k8s-node-condition branch October 25, 2023 07:40
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Add new k8s.node.condition metric, so that we can deprecate
k8s.node.condition_* metrics.


**Link to tracking Issue:** <Issue number if applicable>


open-telemetry#27617

**Testing:** <Describe what testing was performed and which tests were
added.>

- added unit tests

**Documentation:** <Describe the documentation added.>

- added docs
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Add new k8s.node.condition metric, so that we can deprecate
k8s.node.condition_* metrics.


**Link to tracking Issue:** <Issue number if applicable>


open-telemetry#27617

**Testing:** <Describe what testing was performed and which tests were
added.>

- added unit tests

**Documentation:** <Describe the documentation added.>

- added docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants