Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/pdatatest] Ignore span ID for ptracetest #27833

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

sakulali
Copy link
Contributor

Description:
Support ignore span ID in span comparisons for ptracetest.

Link to tracking Issue:
#27685

Testing:
make chlog-validate
go test for pdatatest

Documentation:

@sakulali sakulali force-pushed the fix-ptracetest-spanid branch from fd6d2c1 to b9c863f Compare October 18, 2023 09:31
Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 4b41ec6 into open-telemetry:main Oct 19, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 19, 2023
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2023
**Description:** 
Support ignore span ID in span comparisons for ptracetest.

**Link to tracking Issue:** 

open-telemetry#27685

**Testing:** 
make chlog-validate 
go test for pdatatest

**Documentation:**
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
**Description:** 
Support ignore span ID in span comparisons for ptracetest.

**Link to tracking Issue:** 

open-telemetry#27685

**Testing:** 
make chlog-validate 
go test for pdatatest

**Documentation:**
@sakulali sakulali deleted the fix-ptracetest-spanid branch November 2, 2023 13:56
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:** 
Support ignore span ID in span comparisons for ptracetest.

**Link to tracking Issue:** 

open-telemetry#27685

**Testing:** 
make chlog-validate 
go test for pdatatest

**Documentation:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants