[k8sclusterreceiver] deprecate opencensus.resourcetype attribute #27584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
k8sclusterreceiver-deprecate-opencensus
branch
from
9212e8a to
f362025
Compare
TylerHelmuth
approved these changes
Oct 10, 2023
dmitryax
approved these changes
Oct 10, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
open-telemetry#27616) **Description:** This resource attribute was deprecated in prior release ( open-telemetry#27584) so I am removing it. **Link to tracking Issue:** open-telemetry#26487
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…tribute (open-telemetry#27584) Manually tested, built and image and manually enabled and disabled this resource attribute. This is the warning we publish: > {"level":"warn","ts":1696935210.905353,"caller":"metadata/generated_metrics.go:2201","msg":"[WARNING] `opencensus.resourcetype` should not be configured: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"}
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
open-telemetry#27616) **Description:** This resource attribute was deprecated in prior release ( open-telemetry#27584) so I am removing it. **Link to tracking Issue:** open-telemetry#26487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate opencensus.resourcetype resource attribute.
This PR disables this resource attribute and adds a warning message.
Link to tracking Issue:
#26487
Testing:
Manually tested, built and image and manually enabled and disabled this resource attribute.
This is the warning we publish:
Documentation: