[exporter/kafka] do not expose method #27583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Oct 10, 2023
atoulme
approved these changes
Oct 11, 2023
44 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
songy23
added
ready to merge
codeboten
approved these changes
Oct 26, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
Do not export function WithTracesMarshalers, WithMetricsMarshalers, WithLogsMarshalers and pass checkapi open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for kafkaexporter Co-authored-by: Alex Boten <[email protected]>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Do not export function WithTracesMarshalers, WithMetricsMarshalers, WithLogsMarshalers and pass checkapi open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for kafkaexporter Co-authored-by: Alex Boten <[email protected]>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
Do not export function WithTracesMarshalers, WithMetricsMarshalers, WithLogsMarshalers and pass checkapi open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for kafkaexporter Co-authored-by: Alex Boten <[email protected]>
|
@sakulali could you expand on why this change was made and if there is any way around this? We rely on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Do not export function WithTracesMarshalers, WithMetricsMarshalers, WithLogsMarshalers and pass checkapi
Link to tracking Issue:
#26304
Testing:
go run cmd/checkapi/main.go .
make chlog-validate
go test for kafkaexporter
Documentation: