Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/k8sobjects] add tests for k8sobjectsreceiver #27569

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

jinja2
Copy link
Contributor

@jinja2 jinja2 commented Oct 9, 2023

Description: Adds an e2e test for the k8sobjectsreceiver to github workflow

Link to tracking Issue: 18395

@jinja2 jinja2 changed the title add tests for k8sobjectsreceiver [chore][receiver/k8sobjects] add tests for k8sobjectsreceiver Oct 9, 2023
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinja2 I think we need a make gotidy.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Oct 10, 2023
@jinja2 jinja2 force-pushed the k8sobjects-e2e branch 2 times, most recently from 3fdd237 to 308f1f1 Compare October 10, 2023 19:16
@jinja2
Copy link
Contributor Author

jinja2 commented Oct 10, 2023

The integration test failing is unrelated to this PR, it is known to be flaky (issue)

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts and we can get this merged 👍🏻

@TylerHelmuth TylerHelmuth merged commit 918a81e into open-telemetry:main Oct 11, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 11, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
…elemetry#27569)

**Description:** Adds an e2e test for the k8sobjectsreceiver to github
workflow
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
[18395](open-telemetry#18395)
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…elemetry#27569)

**Description:** Adds an e2e test for the k8sobjectsreceiver to github
workflow
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
[18395](open-telemetry#18395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/k8sobjects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants