[chore][pkg/stanza] Move reader and reader factory into internal package #27416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-internal-reader
branch
from
050a7f0
to
e61fb69
Compare
djaglowski
force-pushed
the
pkg-stanza-internal-reader
branch
from
e61fb69
to
a008701
Compare
This was referenced Oct 4, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…age (open-telemetry#27416) Follows open-telemetry#27396 This PR creates an internal `reader` package and moves directly related structs into it. I intend to clean up this codebase substantially from here. This is just a first step that creates a crude boundary between concerns. There are many exported fields which can later be abstracted, but currently the codebase has many direct interactions. Tests remain in the `fileconsumer` package for now but will be migrated once there are cleaner interfaces to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #27396
This PR creates an internal
readerpackage and moves directly related structs into it.I intend to clean up this codebase substantially from here. This is just a first step that creates a crude boundary between concerns. There are many exported fields which can later be abstracted, but currently the codebase has many direct interactions. Tests remain in the
fileconsumerpackage for now but will be migrated once there are cleaner interfaces to test.