Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/parquet] Deprecate Parquet Exporter #27290

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[exporter/parquet] Deprecate Parquet Exporter #27290

merged 3 commits into from
Oct 3, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 2, 2023

Description:
Deprecate Parquet exporter before removing it altogether.

Link to tracking Issue:
#27285

@atoulme atoulme requested review from a team and evan-bradley October 2, 2023 13:06
@atoulme atoulme force-pushed the deprecate_parquet branch from 4e74416 to 499077c Compare October 2, 2023 13:07
@mx-psi
Copy link
Member

mx-psi commented Oct 2, 2023 

Error: otelcontribcol/exporters_test.go:51:2: SA1019: "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter" is deprecated: this component is no longer developed and will be removed in the next release. (staticcheck)
	"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter"
	^

crobert-1
crobert-1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #27284

@atoulme
Copy link
Contributor Author

atoulme commented Oct 2, 2023

The failure indicates that this is working as intended...

Error: otelcontribcol/exporters_test.go:51:2: SA1019: "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter" is deprecated: this component is no longer developed and will be removed in the next release. (staticcheck)
	"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/parquetexporter"
	^

I will remove the exporter from otelcontribcol in this PR then.

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Oct 2, 2023
@atoulme atoulme force-pushed the deprecate_parquet branch from 9532fa8 to 880e989 Compare October 2, 2023 19:37
@atoulme atoulme requested a review from dmitryax as a code owner October 2, 2023 19:37
@github-actions github-actions bot added the cmd/configschema configschema command label Oct 2, 2023
@github-actions github-actions bot requested a review from pmcollins October 2, 2023 19:38
@mx-psi mx-psi merged commit 949f3e6 into open-telemetry:main Oct 3, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 3, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@atoulme @jmsnll
[exporter/parquet] Deprecate Parquet Exporter (open-telemetry#27290)
53f670b 
**Description:**
Deprecate Parquet exporter before removing it altogether.

**Link to tracking Issue:**
open-telemetry#27285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley

@dmitryax dmitryax Awaiting requested review from dmitryax

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/parquet
Projects
None yet
Milestone
v0.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @mx-psi @crobert-1 @dashpole