[mdatagen] allow to skip metric unit validation #27090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
mdatagen-skip-metric-unit
branch
2 times, most recently
from
375fae4
to
143b1d9
Compare
bertysentry
approved these changes
Sep 27, 2023
mx-psi
reviewed
Sep 28, 2023
povilasv
force-pushed
the
mdatagen-skip-metric-unit
branch
from
143b1d9
to
4378d72
Compare
mx-psi
approved these changes
Sep 28, 2023
dmitryax
approved these changes
Sep 29, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** <Describe what has changed.> Allows setting empty metric units in mdatagen. Example of using it https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27091/files **Tracking Issues:** open-telemetry#27089 open-telemetry#10553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows setting empty metric units in mdatagen.
Example of using it https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27091/files
Link to tracking Issue:
#27089
#10553
Testing:
Documentation: