[receiver/k8sobjects] Extract resource attributes from payload for events #27069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
changed the title
TylerHelmuth
force-pushed
the
k8sobjects-extract-attributes
branch
from
5af5cfd to
5c58174
Compare
|
/cc @jinja2 |
jinja2
reviewed
Oct 5, 2023
TylerHelmuth
force-pushed
the
k8sobjects-extract-attributes
branch
from
f08287a to
cd15e30
Compare
jinja2
reviewed
Oct 5, 2023
|
tests are passing now, PR lgtm! |
jinja2
approved these changes
Oct 5, 2023
|
@TylerHelmuth Would you also change Also I'm wondering if |
|
@sathieu good questions. Can you ask in the issue? That is the place we're collecting potential attributes. |
|
I am going to close this for now as we need to have another discussion with the semconv sig to clarify which Kinds have a semantic convention for name. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the k8sobjects recevier to be able to extract meaningful kubernetes resource attributes from events.
Link to tracking Issue:
Related to #24242
Testing:
Added unit tests and tested locally
Documentation: