[chore] Update approver auto assign config #27033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Sep 20, 2023
crobert-1
approved these changes
Sep 20, 2023
codeboten
approved these changes
Sep 20, 2023
codeboten
reviewed
Sep 20, 2023
codeboten
reviewed
Sep 20, 2023
codeboten
reviewed
Sep 20, 2023
atoulme
approved these changes
Sep 20, 2023
codeboten
reviewed
Sep 20, 2023
I believe sorting was done on the people's names, rather than username. (I was confused about this as well 🙂) |
|
@crobert-1 yeah i saw this after making the suggestions... i found it more confusing than useful tbh |
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
|
CI test failure is unrelated, I've filed #27034. |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Add missing approvers to the auto assign config. I also reorganized the maintainers list to match the ordering of names in the README. Small nit, but it made it easier to compare. --------- Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add missing approvers to the auto assign config. I also reorganized the maintainers list to match the ordering of names in the README. Small nit, but it made it easier to compare.