[cmd/telemetrygen] expose the generated span duration as a command parameter #26991

jmsnll · 2023-09-18T23:41:28Z

Description:

Exposes the duration of generated spans as a command line parameter. It uses a DurationVar flag so units can be easily provided and are automatically applied.

Example usage:

telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ns # nanoseconds
telemetrygen traces --traces 100 --otlp-insecure --span-duration 10us # microseconds
telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ms # milliseconds
telemetrygen traces --traces 100 --otlp-insecure --span-duration 10s # seconds

Testing:

Ran without the argument provided telemetrygen traces --traces 1 --otlp-insecure and seen spans publishing with the default value.

Ran again with the argument provided: telemetrygen traces --traces 1 --otlp-insecure --span-duration 1s

And observed the expected output:

Resource SchemaURL: 
Resource attributes:
     -> service.name: Str(telemetrygen)
ScopeSpans #0
ScopeSpans SchemaURL: 
InstrumentationScope telemetrygen 
Span #0
    Trace ID       : 9718172ff37b17389089b99667ae9522
    Parent ID      : 4eb33cd3ed81dc3e
    ID             : 2d768f6dbde63e7c
    Name           : okey-dokey
    Kind           : Server
    Start time     : 2023-09-18 23:33:18.111136 +0000 UTC   <----
    End time       : 2023-09-18 23:33:19.111136 +0000 UTC   <----
    Status code    : Unset
    Status message : 
Attributes:
     -> net.peer.ip: Str(1.2.3.4)
     -> peer.service: Str(telemetrygen-client)
Span #1
    Trace ID       : 9718172ff37b17389089b99667ae9522
    Parent ID      : 
    ID             : 4eb33cd3ed81dc3e
    Name           : lets-go
    Kind           : Client
    Start time     : 2023-09-18 23:33:18.111136 +0000 UTC   <----
    End time       : 2023-09-18 23:33:19.111136 +0000 UTC   <----
    Status code    : Unset
    Status message : 
Attributes:
     -> net.peer.ip: Str(1.2.3.4)
     -> peer.service: Str(telemetrygen-server)
        {"kind": "exporter", "data_type": "traces", "name": "logging"}

Documentation: No documentation added.

…rameter

jpkrohling

I think we have tests that could be used to exercise this. Can you double-check and add one accordingly?

- previous approach depended on a second call of `time.Now()` which differed in value from the spans start time and introduced variance to the duration - both start and end times are now set for both parent and child spans - added test to ensure start and end times match the duration provided exactly

jmsnll · 2023-09-20T13:32:16Z

I think we have tests that could be used to exercise this. Can you double-check and add one accordingly?

There was indeed! In adding the test I've also fixed a bug in the implementation, now the durations of spans always match the exact duration provided.

github-actions · 2023-10-06T05:19:49Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

jmsnll · 2023-10-06T07:51:26Z

I will look at this today to get the branch updated

github-actions · 2023-10-22T05:19:24Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-11-06T05:19:47Z

Closed as inactive. Feel free to reopen if this PR is still being worked on.

#29116) **Description:** As originally proposed in #26991 before I got distracted Exposes the duration of generated spans as a command line parameter. It uses a `DurationVar` flag so units can be easily provided and are automatically applied. Example usage: ```bash telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ns # nanoseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10us # microseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ms # milliseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10s # seconds ``` **Testing:** Ran without the argument provided `telemetrygen traces --traces 1 --otlp-insecure` and seen spans publishing with the default value. Ran again with the argument provided: `telemetrygen traces --traces 1 --otlp-insecure --span-duration 1s` And observed the expected output: ``` Resource SchemaURL: https://opentelemetry.io/schemas/1.4.0 Resource attributes: -> service.name: Str(telemetrygen) ScopeSpans #0 ScopeSpans SchemaURL: InstrumentationScope telemetrygen Span #0 Trace ID : 8b441587ffa5820688b87a6b511d634c Parent ID : 39faad428638791b ID : 88f0886894bd4ee2 Name : okey-dokey Kind : Server Start time : 2023-11-12 02:05:07.97443 +0000 UTC End time : 2023-11-12 02:05:08.97443 +0000 UTC Status code : Unset Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-client) Span #1 Trace ID : 8b441587ffa5820688b87a6b511d634c Parent ID : ID : 39faad428638791b Name : lets-go Kind : Client Start time : 2023-11-12 02:05:07.97443 +0000 UTC End time : 2023-11-12 02:05:08.97443 +0000 UTC Status code : Unset Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-server) {"kind": "exporter", "data_type": "traces", "name": "debug"} ``` **Documentation:** No documentation added. --------- Co-authored-by: Pablo Baeyens <[email protected]>

open-telemetry#29116) **Description:** As originally proposed in open-telemetry#26991 before I got distracted Exposes the duration of generated spans as a command line parameter. It uses a `DurationVar` flag so units can be easily provided and are automatically applied. Example usage: ```bash telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ns # nanoseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10us # microseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10ms # milliseconds telemetrygen traces --traces 100 --otlp-insecure --span-duration 10s # seconds ``` **Testing:** Ran without the argument provided `telemetrygen traces --traces 1 --otlp-insecure` and seen spans publishing with the default value. Ran again with the argument provided: `telemetrygen traces --traces 1 --otlp-insecure --span-duration 1s` And observed the expected output: ``` Resource SchemaURL: https://opentelemetry.io/schemas/1.4.0 Resource attributes: -> service.name: Str(telemetrygen) ScopeSpans #0 ScopeSpans SchemaURL: InstrumentationScope telemetrygen Span #0 Trace ID : 8b441587ffa5820688b87a6b511d634c Parent ID : 39faad428638791b ID : 88f0886894bd4ee2 Name : okey-dokey Kind : Server Start time : 2023-11-12 02:05:07.97443 +0000 UTC End time : 2023-11-12 02:05:08.97443 +0000 UTC Status code : Unset Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-client) Span #1 Trace ID : 8b441587ffa5820688b87a6b511d634c Parent ID : ID : 39faad428638791b Name : lets-go Kind : Client Start time : 2023-11-12 02:05:07.97443 +0000 UTC End time : 2023-11-12 02:05:08.97443 +0000 UTC Status code : Unset Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-server) {"kind": "exporter", "data_type": "traces", "name": "debug"} ``` **Documentation:** No documentation added. --------- Co-authored-by: Pablo Baeyens <[email protected]>

[cmd/telemetrygen] expose the generated span duration as a command pa…

cff6017

…rameter

jmsnll requested review from mx-psi and codeboten as code owners September 18, 2023 23:41

jmsnll requested a review from a team September 18, 2023 23:41

github-actions bot assigned jpkrohling Sep 18, 2023

github-actions bot added the cmd/telemetrygen telemetrygen command label Sep 18, 2023

James Neill and others added 3 commits September 19, 2023 00:41

chore: add chloggen entry

d82d5fd

Merge branch 'main' into feat/random-fake-span-durations

2337cda

style: run gci tool to fix linting issue

9ef99c7

jmsnll force-pushed the feat/random-fake-span-durations branch from 3dd0039 to 9ef99c7 Compare September 19, 2023 13:47

jpkrohling reviewed Sep 20, 2023

View reviewed changes

jmsnll force-pushed the feat/random-fake-span-durations branch from 7524e54 to e8099c3 Compare September 20, 2023 13:28

atoulme approved these changes Sep 21, 2023

View reviewed changes

mx-psi requested a review from jpkrohling September 21, 2023 07:57

github-actions bot added the Stale label Oct 6, 2023

github-actions bot removed the Stale label Oct 7, 2023

github-actions bot added the Stale label Oct 22, 2023

github-actions bot closed this Nov 6, 2023

jmsnll mentioned this pull request Nov 12, 2023

[cmd/telemetrygen] expose the generated span duration as a command pa… #29116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cmd/telemetrygen] expose the generated span duration as a command parameter #26991

[cmd/telemetrygen] expose the generated span duration as a command parameter #26991

jmsnll commented Sep 18, 2023 •

edited

Loading

jpkrohling left a comment

jmsnll commented Sep 20, 2023

github-actions bot commented Oct 6, 2023

jmsnll commented Oct 6, 2023

github-actions bot commented Oct 22, 2023

github-actions bot commented Nov 6, 2023

[cmd/telemetrygen] expose the generated span duration as a command parameter #26991

[cmd/telemetrygen] expose the generated span duration as a command parameter #26991

Conversation

jmsnll commented Sep 18, 2023 • edited Loading

jpkrohling left a comment

Choose a reason for hiding this comment

jmsnll commented Sep 20, 2023

github-actions bot commented Oct 6, 2023

jmsnll commented Oct 6, 2023

github-actions bot commented Oct 22, 2023

github-actions bot commented Nov 6, 2023

jmsnll commented Sep 18, 2023 •

edited

Loading