Add test to Validate if duplicate metrics are intentional #26687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: open-telemetry#26499 If semantic conventions on the duplicate metric exist, validating is a matter of ensuring they both fulfill semantic intent. For Validating duplicate metrics for which there is no semantic conventions, additional discussion is needed with the semantic conventions WG as mentioned in the issue. For the time being, it will be best judgment.
songy23
reviewed
Sep 14, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
cc @dmitryax can you please take a look ? |
mx-psi
approved these changes
Oct 16, 2023
|
cc @dmitryax bumping this one again, let me know if you have any concerns with adding this ? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Nov 14, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…etry#26687) **Description:** This test alerts a user if a metric is duplicated across receivers, and instructs the user to add said metric to an allow list if this is intentional. If semantic conventions on the duplicate metric exist, validating is a matter of ensuring they both fulfill semantic intent. For validating duplicate metrics for which there is no semantic conventions, additional discussion is needed with the semantic conventions WG as mentioned in the issue. For the time being, it will be best judgment. **Link to tracking Issue:** open-telemetry#26499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This test alerts a user if a metric is duplicated across receivers, and instructs the user to add said metric to an allow list if this is intentional.
If semantic conventions on the duplicate metric exist, validating is a matter of ensuring they both fulfill semantic intent. For validating duplicate metrics for which there is no semantic conventions, additional discussion is needed with the semantic conventions WG as mentioned in the issue. For the time being, it will be best judgment.
Link to tracking Issue: #26499