Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alertmanager): Add exporter config and implementation #26535

Closed
wants to merge 1 commit into from

Conversation

mcube8
Copy link
Member

@mcube8 mcube8 commented Sep 8, 2023

Description: Implementation of Alertmanager Exporter
Span Events are exported to Prometheus Alertmanager

Link to tracking Issue: #23659

Testing: Unit tests for config, factory and alertmanager exporter implementation

Documentation: Readme and Sample Configs to use Alertmanager exporter

@mcube8 mcube8 requested review from a team and dmitryax September 8, 2023 11:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 8, 2023
@sokoide
Copy link
Member

sokoide commented Oct 13, 2023

Hello @codeboten, we'd like to have the accepted feature implemented and have a working code in our end. If this PR didn't look good, could you kindly advise how we could improve it when we reopen or open a new PR for this? Thank you!

@jpkrohling jpkrohling reopened this Oct 16, 2023
@jpkrohling
Copy link
Member

I'm reopening, this is on me to review.

@jpkrohling jpkrohling assigned jpkrohling and unassigned codeboten Oct 16, 2023
@jpkrohling jpkrohling requested review from jpkrohling and removed request for dmitryax October 16, 2023 10:12
@sokoide
Copy link
Member

sokoide commented Oct 16, 2023

@jpkrohling, I appreciate it!

@github-actions github-actions bot removed the Stale label Oct 17, 2023
@jpkrohling
Copy link
Member

@sokoide , @mcube8, to help expedite this review, would you be able to split this PR into two? The first would contain everything except the actual exporter implementation, and the second would contain only the implementation. This way, I can focus on the structural parts first, and on the business later.

exporter/alertmanagerexporter/README.md Show resolved Hide resolved
exporter/alertmanagerexporter/README.md Show resolved Hide resolved
exporter/alertmanagerexporter/README.md Show resolved Hide resolved
exporter/alertmanagerexporter/factory.go Show resolved Hide resolved
exporter/alertmanagerexporter/factory.go Show resolved Hide resolved
exporter/alertmanagerexporter/factory.go Show resolved Hide resolved
exporter/alertmanagerexporter/factory.go Show resolved Hide resolved
exporter/alertmanagerexporter/factory.go Show resolved Hide resolved
@mcube8
Copy link
Member Author

mcube8 commented Nov 6, 2023

This pull request has been split and new pull requests have been raised, closing this.

@mcube8 mcube8 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants