[processor/resourcedetectionprocessor] add k8snode detector #26524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
3 times, most recently
from
488d4c1 to
0c74b08
Compare
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
2 times, most recently
from
caff211 to
5d5dc7e
Compare
github-actions
bot
requested review from
dineshg13,
gbbr,
liustanley and
mackjmr
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
from
5d5dc7e to
3274bdf
Compare
|
@dloucasfx please rebase |
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
8 times, most recently
from
093e05b to
f7022db
Compare
dmitryax
reviewed
Sep 13, 2023
processor/resourcedetectionprocessor/internal/k8snode/metadata.yaml
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/k8snode/config.go
Outdated
Show resolved
Hide resolved
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
3 times, most recently
from
b8ba4ec to
a6a1d2f
Compare
dmitryax
approved these changes
Sep 18, 2023
dmitryax
added
the
ready to merge
mx-psi
approved these changes
Sep 18, 2023
processor/resourcedetectionprocessor/internal/k8snode/config.go
Outdated
Show resolved
Hide resolved
|
@dloucasfx LGTM. Please rebase once more |
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
2 times, most recently
from
440ee26 to
2fc1c21
Compare
mx-psi
approved these changes
Sep 19, 2023
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
2 times, most recently
from
1ac1d25 to
d276719
Compare
codeboten
reviewed
Sep 19, 2023
processor/resourcedetectionprocessor/internal/k8snode/config_test.go
Outdated
Show resolved
Hide resolved
mx-psi
reviewed
Sep 20, 2023
|
@dloucasfx it needs another rebase :( |
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
from
6db8ffb to
6a322e8
Compare
Signed-off-by: Dani Louca <[email protected]>
dloucasfx
force-pushed
the
resourcedetection_k8snode
branch
from
6a322e8 to
1fc5dd5
Compare
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…emetry#26524) **Description:** <Describe what has changed.> Adding k8snode detector to the resourcedetection processor. We currently have no way to attach the k8s node UID attribute to logs/metrics/traces , this detector allows such an attribute to be added. Note: We can add more node attributes if needed, but atm only `k8s.node.uis` is added Signed-off-by: Dani Louca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding k8snode detector to the resourcedetection processor.
We currently have no way to attach the k8s node UID attribute to logs/metrics/traces , this detector allows such an attribute to be added.
Note: We can add more node attributes if needed, but atm only
k8s.node.uisis addedLink to tracking Issue:
Testing:
Unit test, mock tests and manual validation
Documentation:
See Readme