Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append prometheus type and unit suffixes by default in prometheus exporters #26489

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 6, 2023

Description:
Part of #26488

@open-telemetry/wg-prometheus

Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Sep 7, 2023
@dmitryax dmitryax merged commit c03c234 into open-telemetry:main Sep 7, 2023
96 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 7, 2023
codeboten pushed a commit that referenced this pull request Sep 25, 2023
Update documentation to align with the current state of
the pkg.translator.prometheus.NormalizeName feature gate, which was
changed in this PR:
#26489
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…ry#27081)

Update documentation to align with the current state of
the pkg.translator.prometheus.NormalizeName feature gate, which was
changed in this PR:
open-telemetry#26489
@dashpole dashpole deleted the enable_normalize branch November 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/translator/prometheus ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants