[receiver/hostmetrics] make sure process scraper uses root_path config entry #26479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
use_context_in_process_scraper
branch
4 times, most recently
from
234f912
to
3834140
Compare
dmitryax
reviewed
Sep 11, 2023
atoulme
force-pushed
the
use_context_in_process_scraper
branch
from
3834140
to
fd0d4f4
Compare
|
@atoulme please rebase |
atoulme
force-pushed
the
use_context_in_process_scraper
branch
from
d09811b
to
a251260
Compare
mx-psi
reviewed
Sep 14, 2023
|
@dmitryax ready for you I think? |
mx-psi
approved these changes
Sep 21, 2023
atoulme
force-pushed
the
use_context_in_process_scraper
branch
from
95af9fa
to
b0e298f
Compare
dmitryax
approved these changes
Sep 22, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…g entry (open-telemetry#26479) **Description:** A regression introduced in 0.82.0 means that the process scraper doesn't properly respect the `root_path` configuration key when it comes to reading process information. **Link to tracking Issue:** Fixes open-telemetry#24777 --------- Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A regression introduced in 0.82.0 means that the process scraper doesn't properly respect the
root_pathconfiguration key when it comes to reading process information.Link to tracking Issue:
Fixes #24777
Testing:
Unit tests fixes and new end to end tests.
Documentation:
N/A