-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update awscloudwatchlogs exporter to pass apicheck #26366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
label
Sep 1, 2023
atoulme
approved these changes
Sep 1, 2023
44 tasks
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 1, 2023
This was referenced Sep 3, 2023
codeboten
approved these changes
Sep 6, 2023
Please resolve the conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: CWL Logs exporter was using an alias for the exporter package to avoid a naming conflict. I renamed the internal struct to resolve the error and remove the need for the alias. I did not create a breaking changelog entry for this as no api surface was changed.
Link to tracking Issue: #26304