Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/kafkaexporter] Add option to disable kerberos PA_FX_FAST #26346

Closed

Conversation

swythan
Copy link

@swythan swythan commented Aug 31, 2023

Description:

Adds a disable_fast_negotiation config option to the kafkareceiver, kafkametricsreceiver and kafkaexporter that allows PA_FX_FAST pre-authentication FAST negotiation to be disabled. This is required to allow auth using (some?) ActiveDirectory controllers.

See:
https://github.com/jcmturner/gokrb5/blob/master/USAGE.md#active-directory-kdc-and-fast-negotiation

I named the option to match a similar one in Vault.
https://developer.hashicorp.com/vault/docs/auth/kerberos#disable_fast_negotiation

Link to tracking Issue: #26345

Testing:
I've added a unit tetst to check that it is plumbed through to the sarama library, but I've not tested the built binary.

I'd appreciate any guidance there, as I'd have to get a collector docker image built with this change.

Documentation:
I've added the option to the relevant README files.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@swythan swythan changed the title 26345_kafka_DisablePAFXFAST Add config option to disable kerberos PA_FX_FAST in kfaka components Aug 31, 2023
@swythan swythan changed the title Add config option to disable kerberos PA_FX_FAST in kfaka components Add config option to disable kerberos PA_FX_FAST in kafka components Aug 31, 2023
@swythan swythan changed the title Add config option to disable kerberos PA_FX_FAST in kafka components [exporter/kafkaexporter] Add option to disable kerberos PA_FX_FAST Sep 9, 2023
@swythan
Copy link
Author

swythan commented Sep 25, 2023

A quick update on testing:

I managed to get this patched into a ~0.81 copy of the source, and deployed it in my company network. I'm pretty sure the config option is wired up properly and effective, but I'm now getting a different problem getting the connection working (unexpected EOF which isn't super-helpful).

I think this patch is still useful, but I don't yet know whether it's enough to authenticate fully with a Windows AD controller.

@mguggi
Copy link

mguggi commented Oct 5, 2023

For us, this PR would be very useful!

@bogdandrutu Is there any plan when this PR can be merged? In our environment, the kafkareceiver would only work if we can turn off the FAST negotiation.

@swythan
Copy link
Author

swythan commented Oct 6, 2023

@mguggi Have you tested this?

I'm trying to test in my environment, but I've not been able to get past my problem above. If you can verify it's working for you I'm sure that would help in getting it merged.

@mguggi
Copy link

mguggi commented Oct 6, 2023

@swythan Yes, I've tested your changes and they work in our environment.

I created a fork yesterday, from the main branch (~v0.86.0), and created a PR from the branch (swythan:26345_kafka_DisablePAFXFAST) of your fork. After applying the PR and building the binary, my configuration worked as desired.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 21, 2023
@swythan
Copy link
Author

swythan commented Oct 22, 2023

@bogdandrutu Do you need anything from me to get this merged?

I suspect I'll not be able to get much further testing in my environment very soon, but @mguggi was able to test that it actually works and I don't think it's particularly complex or controversial.

@github-actions github-actions bot removed the Stale label Oct 23, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 7, 2023
@swythan
Copy link
Author

swythan commented Nov 7, 2023

This is still active. Waiting on @bogdandrutu

@github-actions github-actions bot removed the Stale label Nov 8, 2023
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 23, 2023
@mguggi
Copy link

mguggi commented Nov 23, 2023

This is still active. Still waiting on @bogdandrutu

@github-actions github-actions bot removed the Stale label Nov 25, 2023
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 10, 2023
@alexk82
Copy link

alexk82 commented Dec 11, 2023

I'm also waiting for this PR to be merged.

Can I somehow support to get this merged?

@github-actions github-actions bot removed the Stale label Dec 12, 2023
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@swythan
Copy link
Author

swythan commented Jan 4, 2024

Looks like the code has been restructured in main. It shouldn't be too difficult to re-do this PR if there's any chance of it getting merged.

@github-actions github-actions bot removed the Stale label Jan 5, 2024
@mguggi
Copy link

mguggi commented Jan 11, 2024

@bogdandrutu, @pavolloffay or @dmitryax Are there any plans to fix this problem in upcoming releases?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 26, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants