-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/kafkaexporter] Add option to disable kerberos PA_FX_FAST #26346
Conversation
A quick update on testing: I managed to get this patched into a ~0.81 copy of the source, and deployed it in my company network. I'm pretty sure the config option is wired up properly and effective, but I'm now getting a different problem getting the connection working ( I think this patch is still useful, but I don't yet know whether it's enough to authenticate fully with a Windows AD controller. |
For us, this PR would be very useful! @bogdandrutu Is there any plan when this PR can be merged? In our environment, the |
@swythan Yes, I've tested your changes and they work in our environment. I created a fork yesterday, from the main branch |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@bogdandrutu Do you need anything from me to get this merged? I suspect I'll not be able to get much further testing in my environment very soon, but @mguggi was able to test that it actually works and I don't think it's particularly complex or controversial. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This is still active. Waiting on @bogdandrutu |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This is still active. Still waiting on @bogdandrutu |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
I'm also waiting for this PR to be merged. Can I somehow support to get this merged? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Looks like the code has been restructured in |
@bogdandrutu, @pavolloffay or @dmitryax Are there any plans to fix this problem in upcoming releases? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Adds a
disable_fast_negotiation
config option to thekafkareceiver
,kafkametricsreceiver
andkafkaexporter
that allowsPA_FX_FAST
pre-authentication FAST negotiation to be disabled. This is required to allow auth using (some?) ActiveDirectory controllers.See:
https://github.com/jcmturner/gokrb5/blob/master/USAGE.md#active-directory-kdc-and-fast-negotiation
I named the option to match a similar one in Vault.
https://developer.hashicorp.com/vault/docs/auth/kerberos#disable_fast_negotiation
Link to tracking Issue: #26345
Testing:
I've added a unit tetst to check that it is plumbed through to the sarama library, but I've not tested the built binary.
I'd appreciate any guidance there, as I'd have to get a collector docker image built with this change.
Documentation:
I've added the option to the relevant README files.