Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][fileconsumer] Cleanup file handle when closed by reader #26030

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Aug 22, 2023

Reboot of #25912

@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Aug 22, 2023
@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-reader-close branch from 7a4d50c to c02ed80 Compare August 22, 2023 14:01
@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-reader-close branch from 43d9e52 to 3bc54de Compare August 22, 2023 17:57
@djaglowski djaglowski marked this pull request as ready for review August 22, 2023 20:00
@djaglowski djaglowski requested review from a team and fatsheep9146 August 22, 2023 20:00
@djaglowski djaglowski requested a review from codeboten August 28, 2023 14:04
@djaglowski
Copy link
Member Author

This is ready for review

@djaglowski djaglowski merged commit 9d5ec53 into open-telemetry:main Sep 5, 2023
@djaglowski djaglowski deleted the pkg-stanza-fileconsumer-reader-close branch September 5, 2023 14:16
@github-actions github-actions bot added this to the next release milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants