[exporter/awsemf] Enforce TTL on metric calculator maps #25066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/awsemf
Aneurysm9
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR implements a ticker to automatically enforce the TimeToLive value on
MapWithExpiryobjects inside theinternal/aws/metricspackage. This map object is used directly by the Container Insights receiver and the MetricCalculator object in the same package. Metric calculators are used by the EMF Exporter.Changes to container insights receiver interfaces had to be made so that shutdown on all calculators could be enforced.
In the EMF Exporter, the
metrictranslatorobject now owns anemfCalculatorobject which can be passed down to the data point interface. The metric translator now has a shutdown method which can be called by the emf exporter on close.Link to tracking Issue: Closes #25058
Testing:
Documentation: