[processor/resourcedetectionprocessor] handle partial presence of heroku metadata #25059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
atoulme
force-pushed
the
heroku_partial_metadata
branch
4 times, most recently
from
fd029c7 to
3410f1b
Compare
atoulme
force-pushed
the
heroku_partial_metadata
branch
from
3410f1b to
9021a7e
Compare
MovieStoreGuy
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, heroku metadata is only collected if the
HEROKU_DYNO_IDenvironment variable is present.It turns that under some circumstances this environment variable may be missing, but the rest of the variables may still be present. We collect what we can and offer to log at debug level if some or all metadata is missing to avoid cluttering logs.
Testing:
Unit tests.
Documentation:
No changes.