-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza/fileconsumer] Add trie and test cases #24982
[pkg/stanza/fileconsumer] Add trie and test cases #24982
Conversation
@djaglowski I created this new PR. The previous one will be a mess if I revert in the same PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests in this PR are substantially less thorough than those I contributed in VihasMakwana#2.
Those cases were designed to give me confidence that the trie behaves as I expected. We've agreed to remove Put
's ability to update fingerprints, but this should only affect some specific assertions. All of those sequences should still be tested. Will you please restore the test cases and change only the assertions directly related to the Put
function's update capability?
@djaglowski done, sorry bout that. |
|
I agree. I'm going through my test cases in enough detail that I'm just going to make another PR to update the assertions as I understand them now. |
sounds fair, you'd wanna be sure that TRIE behaves as expected. |
I can add you to my repo, you can commit directly if you want to? |
That's ok. I'd prefer to do it through PR anyways 👍 |
I made the PR. Tests passed all my expectations now. I'll take another look tomorrow with fresh eyes but I think this may be good to go. |
@VihasMakwana, my PR is here. It also includes some lint fixes. |
Update test cases with new expectations
@djaglowski I think we are good to go. I believe we can skip the changelog for this, as we did for my previous PR. I will include trie in threadpool PR's changelog. |
I agree with skipping the changelog. Ultimately, this is an internal package and not in itself a user-facing concern. We'll add a changelog describing the user-facing behavior that it enables, when the rest of the solution is in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for persisting on this @VihasMakwana. I'm looking forward to seeing how well it supports the concurrent handling of files that we're aiming for.
Description: Add Trie data structure and keep it separate from PR #23056
Testing: Relevant test cases added