[receiver/datadog] Test case level retries for flaky DD receiver integration test #24857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component.Start calls on same port
zcross
changed the title
zcross
commented
Aug 3, 2023
| func startComponentWithRetries(ctx context.Context, component component.Component, host component.Host) error { | ||
| return backoff.Retry(func() error { | ||
| return component.Start(ctx, host) | ||
| }, backoff.WithMaxRetries(backoff.NewConstantBackOff(time.Second), 5)) |
There was a problem hiding this comment.
Maintainers: feel free to fiddle with the parameters here (e.g., feel free to edit on-PR yourself). I just wanted to point out the flake and propose a fix. I wouldn't want to use too many retries to slow down overall build times and mask an issue that should be fixed more structurally. However, I think that it makes sense for the integration test to use the expected standard port instead of a randomly generated (guaranteed-not-in-use) port.
There was a problem hiding this comment.
Or, alternatively, we can just mash the two test cases (functions) in this suite (file) into one which will guarantee serial execution of their steps regardless of -parallel N invocations of gotest in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hopefully reduces the probability (without guaranteeing anything, because test executions have a timeout of a few minutes and shouldn't spend a lot of time retrying) of this class of test flake:
E.g., https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5752929108/job/15595049479
Link to tracking Issue: N/A
Testing: Tests pass locally with same
-parallel Ninvocation used by CIDocumentation: N/A