Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][fileconsumer] Move file finding and filtering into subpackage #24853

Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Aug 3, 2023

This PR extracts all file finding, sorting, and filtering into a dedicated matcher package.

  • The matcher package is exported, as it contains several config structs. However, much of the code is further delegated to internal packages.
  • Simplifies config struct unmarshaling, without any user-facing changes to config
  • Deprecates corresponding config structs in fileconsumer package
  • Hardens configuration validation
  • Ensures that when sortation fails on some files, others can still be read
  • Ensures that files that can not be sorted are not read
  • Verbose error communication when files cannot be sorted
  • 100% test coverage across matcher package and its internal packages

@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-sort branch 2 times, most recently from 61e68bc to ad3ec13 Compare August 3, 2023 18:02
@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-sort branch from ad3ec13 to 53121ab Compare August 3, 2023 18:25
@github-actions github-actions bot requested a review from atoulme August 3, 2023 18:26
@djaglowski djaglowski marked this pull request as ready for review August 3, 2023 18:52
@djaglowski djaglowski requested a review from a team August 3, 2023 18:52
@djaglowski djaglowski merged commit 70946c9 into open-telemetry:main Aug 4, 2023
@djaglowski djaglowski deleted the pkg-stanza-fileconsumer-sort branch August 4, 2023 13:00
@github-actions github-actions bot added this to the next release milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants