-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add syslog receiver support #2482
add syslog receiver support #2482
Conversation
opentelemetry-log-collector syslog parser has a bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. A few comments, and one more blocker on log-collection
repo.
@wph95 thank you for working on this. I will assign the issue to you. Please remember to claim issues if you want to work on them in the future. We will also need a perf test for syslog receiver. If you do not plan on implement a perf test in this PR please create a separate issue for that. |
thx Tigran, next time will claim issues first :) |
Codecov Report
@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 91.48% 91.51% +0.02%
==========================================
Files 440 441 +1
Lines 21864 21887 +23
==========================================
+ Hits 20002 20029 +27
+ Misses 1393 1390 -3
+ Partials 469 468 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@wph95 The latest release of On this PR, I think we only need to change the docs from |
changed docs, from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks @wph95!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @wph95. I believe this is ready to go.
/cc @tigrannajaryan |
Thank you @wph95 ! |
Add Syslog receiver **Link to tracking Issue:** #2331 **Testing:** Unit tests are included **Documentation:** Syslog receiver README.md is included
Co-authored-by: Tyler Yahn <[email protected]>
Description: Add Syslog receiver
Link to tracking Issue: #2331
Testing: Unit tests are included
Documentation: Syslog receiver README.md is included