Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/mdatagen] Avoid reusing the same ResourceBuilder instance #24762

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[cmd/mdatagen] Avoid reusing the same ResourceBuilder instance #24762

merged 1 commit into from
Aug 1, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Aug 1, 2023 •
edited
Loading

Add a method to MetricsBuilder to create new instances of ResourceBuilder from the existing configuration instead of creating the ResourceBuilder separately and reusing the same instance for different ResourceMetrics. This allows concurrent usage of the ResourceBuilder instances, which is already needed in k8scluster receiver.

@dmitryax dmitryax requested a review from djaglowski as a code owner August 1, 2023 04:00
@dmitryax dmitryax requested a review from a team August 1, 2023 04:00
@dmitryax dmitryax changed the title [cmd/mdatagen] Avoid reusing the same ResourceBuilder [cmd/mdatagen] Avoid reusing the same ResourceBuilder instance Aug 1, 2023
@dmitryax dmitryax force-pushed the mdatagen-combine-resource-builder branch 2 times, most recently from 5bf1b82 to b167129 Compare August 1, 2023 04:04
@dmitryax
[cmd/mdatagen] Avoid reusing the same ResourceBuilder
45dd0e5 
Add an option to MetricsBuilder to create new instances of ResourceBuilder instead of reusing the same builder for all ResourceMetrics and apply this approach. This allows concurrent usage of the ResourceBuilder instances which is already needed in k8scluster receiver.
@dmitryax dmitryax force-pushed the mdatagen-combine-resource-builder branch from b167129 to 45dd0e5 Compare August 1, 2023 04:16
@dmitryax dmitryax merged commit 29ea5a9 into open-telemetry:main Aug 1, 2023
@github-actions github-actions bot added this to the next release milestone Aug 1, 2023
@dmitryax dmitryax deleted the mdatagen-combine-resource-builder branch August 5, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

Assignees

@evan-bradley evan-bradley

Labels
cmd/mdatagen mdatagen command receiver/activedirectoryds receiver/aerospike receiver/apache receiver/apachespark receiver/bigip receiver/chrony receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/filestats receiver/flinkmetrics receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/iis receiver/k8scluster receiver/kafkametrics receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mongodbatlas receiver/mysql receiver/nginx receiver/nsxt NSXT Receiver receiver/oracledb receiver/postgresql receiver/rabbitmq
Projects
None yet
Milestone
v0.83.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitryax @djaglowski @evan-bradley