[pkg/stanza][fileconsumer] Remove/unexport deprecated fields #24688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-fileconsumer-deprecated
branch
from
90a7173 to
20ccd43
Compare
atoulme
approved these changes
Aug 1, 2023
djaglowski
added a commit
that referenced
this pull request
Aug 2, 2023
…24772) Follows #24688 This is an incremental step towards hardening `fileconsumer` package. This isolates the "finding files" logic into its own package. The recently added filtering of files based on additional criteria is left in place for now. It also strengthens the test cases by using actual input, which is often relative, instead of converting everything to absolute paths.
shalper2
added a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileAttributesEmitFuncFinderBaseSortRuleandSortRuleImplReader