telemetrygen: Allow setting custom paths #24551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Jul 25, 2023
The current description for the flag is wrong. ``` ❯ ../../open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen/telemetrygen metrics --otlp-endpoint example.com/v1/metrics --otlp-http --otlp-insecure 2023-07-25T22:03:45.884+0200 INFO metrics/metrics.go:56 starting HTTP exporter Error: failed to obtain OTLP exporter: parse "http://example.com%2Fv1%2Fmetrics/v1/metrics": invalid URL escape "%2F" ``` Signed-off-by: Goutham <[email protected]>
gouthamve
force-pushed
the
telemetrygen-new-path
branch
from
36b2926 to
6ef1b74
Compare
|
@songy23 Done |
mx-psi
added
the
ready to merge
atoulme
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current description for the flag is wrong.
I couldn't make it easily work with the existing flag because
url.Parse(c.Endpoint)puts everything in path, and u.Host is unset. This is because url.Parse expectshttp://orhttps://which is set through a different flag.