Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grafana Agent to list of distributions #24418

Conversation

jpkrohling
Copy link
Member

This adds Grafana Agent as a distribution and mark the respective components as being present there.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling
Copy link
Member Author

@mattdurham, could you please review this one?

@mattdurham
Copy link

Is there a good place to slot in a link to the documentation? If not this looks good. Should we also add a task/reminder to the agent repo to update this every time we add more otel components?

@jpkrohling
Copy link
Member Author

Is there a good place to slot in a link to the documentation?

Not in the contrib repository, I do remember seeing a list of distributions somewhere. I'll try to find it and send a PR there as well.

If not, maybe just grafana given that we keep other distro names short?

True, I'll change that

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 21, 2023
@jpkrohling
Copy link
Member Author

PR is ready for review again.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the span metrics processor was missed in this update

exporter/lokiexporter/README.md Outdated Show resolved Hide resolved
receiver/lokireceiver/README.md Outdated Show resolved Hide resolved
@jpkrohling
Copy link
Member Author

jpkrohling commented Jul 21, 2023

For this PR, I'm including only the Flow components from the documentation page, as they are 1-1 to the OTel components. I'll open another PR if we think that the ones we use in static mode should be included as well.

I removed Loki receiver/exporter for now, as you are correct that they are not 1-1 to the ones we have in this repo here.

@jpkrohling jpkrohling force-pushed the jpkrohling/add-grafana-agent-distribution branch from 5cd759b to dedd995 Compare July 21, 2023 18:21
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling force-pushed the jpkrohling/add-grafana-agent-distribution branch from dedd995 to d00e513 Compare July 21, 2023 18:22
@jpkrohling jpkrohling merged commit 55e2365 into open-telemetry:main Jul 22, 2023
@github-actions github-actions bot added this to the next release milestone Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants