[exporter/awsxray] Fix X-Ray Segment status code #24381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
from
b4f3641 to
0225315
Compare
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
2 times, most recently
from
c5672d7 to
5dae054
Compare
bjrara
reviewed
Jul 19, 2023
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
2 times, most recently
from
df7890f to
c4c3f4a
Compare
|
LGTM |
bjrara
approved these changes
Jul 19, 2023
wangzlei
approved these changes
Jul 19, 2023
|
Hi @dashpole, could you please take a look this PR when you get a chance |
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
from
c4c3f4a to
aaf5c58
Compare
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
from
aaf5c58 to
f0cff2f
Compare
mxiamxia
force-pushed
the
fix-xray-segment-status
branch
from
bec1c24 to
21e9a64
Compare
mxiamxia
added a commit
to amazon-contributing/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2023
|
Hi @dashpole , kindly follow if you could help to take a look this PR. Ty! |
|
Hi can I get some help from @open-telemetry/collector-contrib-approvers to review this PR? |
TylerHelmuth
approved these changes
Jul 31, 2023
jpkrohling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The conversion from HTTP spans to X-Ray segments did not accurately capture the HTTP status code during the translation of the cause. As a result, some failed HTTP requests with 4xx and 5xx status codes were displayed as having an "OK" status in the X-Ray console. Also, add remote attribute in Exception for X-Ray remote segments.
Link to tracking Issue:
N/A
Testing:
unit test
Documentation:
N/A