feat(internal/metadataproviders/system): do not return empty host.id #24239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Jul 13, 2023
added 4 commits
July 14, 2023 10:15
Signed-off-by: Dominik Rosiek <[email protected]>
…etection Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-host-id
branch
from
6005c7c to
47be957
Compare
mx-psi
reviewed
Jul 14, 2023
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
Jul 14, 2023
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Jul 28, 2023
Do not drop all system attributes if `host.id` cannot be fetched. This is a fix that restores the behavior closer to how it used to be before open-telemetry#24239. This probably should be applied to all other attributes going forward: if any of the system attributes cannot be fetched, we should still try to set others. But that will be a significant change in the processor behavior, so it should be handled not as a hotfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Do not return empty host ID
Link to tracking Issue: #24230
Testing: Unit tests
Documentation: N/A